Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common/chains): add garnet #1434

Closed
wants to merge 8 commits into from
Closed

feat(common/chains): add garnet #1434

wants to merge 8 commits into from
+16,754 −18,101

Conversation

qbzzt
Copy link
Collaborator

@qbzzt qbzzt commented Sep 15, 2024 •
edited by coderabbitai bot
Loading

Description

Add the garnet network

Testing

None, I don't know how to release packages to verify, and it's a tiny change.

Additional Information

Your ENS/address: qbzzt.eth

Summary by CodeRabbit

  • New Features

    • Introduced a new preset configuration named garnet, enhancing the application's functionality.
    • Added a logging configuration and hardfork versioning to the garnet preset.

  • Documentation

    • Updated exports to include the new garnet module for easier access within the application.
    • Added comments to guide developers on updating documentation links for new chains.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: aeab72f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 56 packages
Name Type
@tevm/common Major
@tevm/sync-storage-persister Major
@tevm/bundler-cache Major
@tevm/base-bundler Major
@tevm/resolutions Major
@tevm/compiler Major
@tevm/unplugin Major
@tevm/whatsabi Major
@tevm/esbuild-plugin Major
@tevm/runtime Major
@tevm/webpack-plugin Major
@tevm/viem-effect Major
@tevm/receipt-manager Major
@tevm/config Major
@tevm/rollup-plugin Major
@tevm/rspack-plugin Major
@tevm/memory-client Major
@tevm/solc Major
@tevm/vite-plugin Major
@tevm/client-types Major
@tevm/bun-plugin Major
@tevm/schemas Major
@tevm/http-client Major
@tevm/precompiles Major
@tevm/blockchain Major
@tevm/decorators Major
@tevm/predeploys Major
@tevm/procedures Major
@tevm/tsupconfig Major
@tevm/ethers Major
@tevm/contract Major
@tevm/actions Major
@tevm/address Major
@tevm/jsonrpc Major
@tevm/viem Major
@tevm/effect Major
@tevm/errors Major
@tevm/logger Major
@tevm/server Major
@tevm/txpool Major
@tevm/block Major
@tevm/state Major
@tevm/utils Major
@tevm/ts-plugin Major
@tevm/node Major
@tevm/trie Major
@tevm/evm Major
@tevm/rlp Major
@tevm/tx Major
@tevm/vm Major
tevm Major
@tevm/cli Major
@tevm/lsp Major
@tevm/test-utils Major
@tevm/experimental-solc Major
tevm-run Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
tevm-monorepo-tevm ⬜️ Ignored (Inspect) Sep 21, 2024 9:19pm

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024 •
edited
Loading

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

213 files out of 295 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new preset configuration for the Garnet chain in the project. A new file, garnet.js, defines a constant redstone with specific logging and hardfork settings. Additionally, the garnet module is exported from the index.js file, making it accessible to other parts of the application. This expansion allows for enhanced modularity and flexibility in utilizing the new preset.

Changes

Files Change Summary
packages/common/src/presets/garnet.js Added a new constant redstone configured with logging level, EIPs array, and hardfork version.
packages/common/src/presets/index.js Added export statement for the garnet module from garnet.js, enhancing module exports.
packages/common/src/index.ts Added garnet to the list of exported presets, making it available for import in other modules.

Poem

🐇 In the land of code where changes bloom,
A new preset rises, dispelling the gloom.
With redstone shining, bright and clear,
Logging and hardforks, we hold dear.
So hop along, let the features play,
For Garnet's here to brighten the day! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

roninjin10
roninjin10 requested changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run pnpm changeset and do a minor release

packages/common/src/presets/garnet.js Outdated Show resolved Hide resolved
roninjin10
roninjin10 requested changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another changeset for all packages patch for updating viem

@qbzzt
Copy link
Collaborator Author

qbzzt commented Sep 15, 2024

Can you add another changeset for all packages patch for updating viem

All of them, or just those that have viem as a dependency?

@roninjin10
Copy link
Collaborator

Either works I usually just do all of them to be safe since it’s in prerelease mode anyways

@qbzzt
Copy link
Collaborator Author

qbzzt commented Sep 15, 2024

Either works I usually just do all of them to be safe since it’s in prerelease mode anyways

That's what I did.

@qbzzt
Copy link
Collaborator Author

qbzzt commented Sep 16, 2024

Can you rerun https://github.com/evmts/tevm-monorepo/actions/runs/10874785545/job/30174220169?pr=1434 ? It failed due to a timeout.

@roninjin10
Copy link
Collaborator

Closing because this pr will be supersceded by #1441 which will generate all these chain files from viem. Viem will also be updated to latest version in an upcoming pr that updates every package to latest

@roninjin10 roninjin10 closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roninjin10 roninjin10 Awaiting requested review from roninjin10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbzzt @roninjin10